Bug 4460 - Broken link in hgweb's search results
Summary: Broken link in hgweb's search results
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: hgweb (show other bugs)
Version: 3.2.1
Hardware: PC All
: urgent bug
Assignee: Anton Shestakov
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2014-11-20 15:54 UTC by Jordi Gutiérrez Hermoso
Modified: 2015-01-22 15:04 UTC (History)
4 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jordi Gutiérrez Hermoso 2014-11-20 15:54 UTC 
The following link

http://selenic.com/hg/search/?rev=jordigh&revcount=20

Followed from "more" or "less" here:

http://selenic.com/hg/log?rev=jordigh

Leads to an error. This is a regression from 3.1
Comment 1 Pierre-Yves David 2014-11-20 15:59 UTC 
I've seen the traceback.
Comment 2 Matt Mackall 2014-11-20 16:28 UTC 
Bisected to:

changeset:   24334:6e1fbcb18a75
branch:      stable
user:        Anton Shestakov <engored@ya.ru>
date:        Mon Sep 22 23:46:38 2014 +0900
summary:     hgweb: fail if an invalid command was supplied in url path (issue4071)
Comment 3 HG Bot 2014-11-22 18:16 UTC 
Fixed by http://selenic.com/repo/hg/rev/c00b156d6e76
Anton Shestakov <engored@ya.ru>
templates: fix broken "less" & "more" links in paper style (issue4460)

"/search", which is an invalid command in hgweb, was mistakenly used for
"[show] more [revsets]" and "[show] less [revsets]" links on search page in
templates "paper" (and those which inherit paper, such as coal) before and
worked fine until 6e1fbcb18a75, which made hgweb more strict about invalid
commands.

(please test the fix)
Comment 4 Matt Mackall 2015-01-22 15:04 UTC 
Bulk testing -> fixed